You are viewing an historical archive of past issues. Please report new issues to the appropriate project issue tracker on GitHub.

Bug #1564: Rails 3: pagination links broken in issue search

Kind bug
Product wincent.dev
When Created , updated
Status closed
Reporter Greg Hurrell
Tags no tags

Description

If we do an issue search with multiple pages of search results, the "next" link ends up being something like the following (split over multiple lines for readability): 

https://localhost:3002/issues/search ?
page=2 &
commit=Search &
authenticity_token=eEHEfv3SFoTtQNACZs9Hj7rb6WHBs3w3H3M6HbTI5Kg%3D &
issue[kind]= &
issue[product_id]= &
issue[status]=0 &
issue[summary]=

This link is broken, however, and clicking on it takes you right back to the search form.

Compare that with the links generated on the live production site (Rails 2): 

https://wincent.dev/issues/search ?
page=2 &
commit=Search &
authenticity_token=2x9hZwvUJcIL%2FcDPxecwEjs9Nh48O%2B%2B4UrN3QDPwjHM%3D &
issue%5Bkind%5D= &
issue%5Bproduct_id%5D= &
issue%5Bstatus%5D=0 &
issue%5Bsummary%5D=

So looks like the Rails 2 one is URL escaped, but the Rails 3 one isn't, causing problems.

Comments

  1. Greg Hurrell

    Cause wasn't URL escaping, of course... Now fixed. Will mark as closed.

  2. Greg Hurrell

    Status changed:

    • From: new
    • To: closed
Add a comment

Comments are now closed for this issue.

Menu