≡

wincent.dev

  • Products
  • Blog
  • Wiki
  • Issues
You are viewing an historical archive of past issues. Please report new issues to the appropriate project issue tracker on GitHub.
Home » Issues » Feature request #1591

Feature request #1591: Use fewer divs in comments lists

Kind feature request
Product wincent.dev
When Created 2010-06-24T09:50:47Z, updated 2010-06-26T11:47:33Z
Status closed
Reporter Greg Hurrell
Tags no tags

Description

Currently the DOM for comments on blog posts (and other similar "commentables") looks like this (using a Haml style syntax):

.comments
  .comment.even
  .comment.odd
  .comment.even
  ...

I think I'd like to replace the outer comments "div" element with a "ul" or "ol" element.

And the inner comment "div" elements with "li" elements. The classes would remain the same:

%ol.comments
  %li.even
  %li.odd
  %li.even

But note how we could drop the comment class off the "li" elements, because they can all be targeted with a selector like ol.comments>li.

So the benefit would be a slightly less verbose markup, and a more semantically faithful "ol" for what is, after all, an "ordered list of comments".

Comments

  1. Greg Hurrell 2010-06-26T11:47:26Z

    This is now done and it seems to work fine with no down sides. Will work as closed.

  2. Greg Hurrell 2010-06-26T11:47:33Z

    Status changed:

    • From: new
    • To: closed
Add a comment

Comments are now closed for this issue.

  • contact
  • legal

Menu

  • Blog
  • Wiki
  • Issues
  • Snippets